-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update react-modal #1319
update react-modal #1319
Conversation
Where is use of ES6 default export documented? Doesn't make any sense, but I guess that is normal for JS libs. |
No, bullshit from my behalf, this is not in the README, sorry, blind faith. I should add this info into the cljsjs.react-modal readme? |
I'm quite sure their webpack build is broken. ES6 export default property is not supposed to be seen on the dist build. |
Ok, could be. This is where I actually found out about the .-default reactjs/react-modal#470 and this is 19 days old, the version Im PR-ing against is 17 hours old. So between at least 2 versions, they haven't fixed it. The problem with the current cljsjs version of react-modal is that it uses deprecated |
Nah, looks like it's failing
Hm, looks broken, twice they feed |
Ok, it's not failing, version 2.3.1 works. The reason I got this message is unknown to me, but I'm building a Greasemonkey user script, and there it failed, in a script tag on html page, it works. @Deraen nice hehe, even better :) I'll watch this PR and react if they fix this and update my PR. |
d2c96a8
to
d67d812
Compare
PR Updated to v2.3.2, regenerated the externes and squashed the two commits. |
Bump to version 2.3.1
Extern: Generated.
Update:
Api canged, now one needs to provide property for the RactModal calls
(.-default js/ReactModal)
for example. This is explained on the readme on their git repo ex.var Modal = (require 'react-modal').default